BUG: avoid validation error for ufunc with string[python] array #62498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Sep 29, 2025
Comment on lines
238
to
+239
| else: | ||
| if self.dtype.type is str: # type: ignore[comparison-overlap] |
There was a problem hiding this comment.
nit: Would be a nice if this was elif so it could be un-indented one level, but not a big deal.
mroeschke
approved these changes
Sep 29, 2025
|
Thanks @jorisvandenbossche |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
jorisvandenbossche
added a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Sep 29, 2025
|
Manual backport -> #62505 |
jorisvandenbossche
added a commit
that referenced
this pull request
Sep 29, 2025
jzwick
pushed a commit
to jzwick/pandas
that referenced
this pull request
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #40800, i.e. fixing the plain error when calling a ufunc that does not return string values on a string array/Series.
There are also issues with the resulting dtype (if the ufunc returns object dtype, should we infer the dtype?), but that is left for another issue (that is also less pressing than fixing the raised error)